Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deere rework styling #2

Merged
merged 3 commits into from
Jan 15, 2017
Merged

Deere rework styling #2

merged 3 commits into from
Jan 15, 2017

Conversation

ronso0
Copy link

@ronso0 ronso0 commented Jan 15, 2017 •
edited
Loading

Did some polish:

  • button grids' layout-spacing now respected

    set SizePolicy to min,min, though this trick doesn't seem to work everywhere, i.e. in vinylcontrols it doesn't

  • button groups in deck_controls_row pushed apart to be distinguish better fro each other
  • fixed EQ kill button appearance on right channel

    when coming from 4deck/stacked_wave they were cut off a the right

  • bigger Pfl buttons: they are important and space is occupied anyway due to greater height/width of surrounding knobs

    did this manually, should there be another Variable in skin.xml for that?

  • spacer_hx.xml added where horizontal dimension can be defined
  • deck buttons: 2px spacing minimal view

    this is working around https://bugs.launchpad.net/mixxx/+bug/1578111 which is 8 months old

Be-ing
Be-ing reviewed Jan 15, 2017
View reviewed changes
res/skins/Deere/equalizer_rack_parameter_right.xml
@@ -19,6 +19,7 @@
<Children>

<SizeAwareStack>
<Size>40f,-1me</Size>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I didn't realize the fix would be so simple. Thanks for figuring that out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, neither did I ;) it was late and I just reversed elements' order in ...left.xml and diffed

@Be-ing Be-ing merged commit b1cfc86 into Be-ing:deere_stacked_waveforms_rework Jan 15, 2017
@Be-ing
Copy link
Owner

Be-ing commented Jan 15, 2017

I like that you increased the PFL button sizes, but I think they're too big now. I'll try making them a size between what they are now and what they were.

@ronso0 ronso0 deleted the deere_rework_styling branch January 16, 2017 10:17
@ronso0
Copy link
Author

ronso0 commented Jan 16, 2017

Okay. We're both @1366x768, I wonder how it looks on bigger screens. When dj'ing with a controller without Pfl button they should be easy to toggle.

@Be-ing
Copy link
Owner

Be-ing commented Jan 16, 2017

Controllers without PFL buttons are rare.

Be-ing pushed a commit that referenced this pull request Jul 13, 2017
@jmigual
Merge pull request #2 from daschuer/libraryFocus
70ed385 
Enable keybord navigation for the search box.
Be-ing pushed a commit that referenced this pull request Dec 20, 2017
@poelzi
Merge pull request #2 from uklotzde/feature/crate_selectbox
7f2e1e7 
Optimize formatting of string lists for SQL queries
Be-ing pushed a commit that referenced this pull request Jun 11, 2018
@gramanas
Merge pull request #2 from ronso0/lib-redesign-LateNight-fix
d9b6033 
LateNight: fix screwed library (lib redesign)
Be-ing pushed a commit that referenced this pull request Apr 23, 2019
@ninomp
Merge pull request #2 from Be-ing/intro_outro_markers
cbefc58 
Intro outro markers skin settings
Be-ing pushed a commit that referenced this pull request Mar 25, 2020
@Holzhaus
Merge pull request #2 from daschuer/serato-library-feature
0ae2bff 
apply changes from git-clang-format
Be-ing pushed a commit that referenced this pull request Apr 8, 2022
@Holzhaus
EngineBuffer: Fix assert when new track is loaded during playback wit…
9614a8f 
…h sync

When loading a track that is not yet present in the library (and thus
doesn't have any BPM because it hasn't been analyzed yet) while another
deck is playing and both decks have sync enabled, a debug assertion is
triggered:

    DEBUG ASSERT: "isValid()" in function double mixxx::Bpm::value() const at src/track/bpm.h:53
    Aborted (core dumped)

The backtrace looks as follows:

    #0  0x00007f175c87234c in __pthread_kill_implementation () at /usr/lib/libc.so.6
    #1  0x00007f175c8254b8 in raise () at /usr/lib/libc.so.6
    #2  0x00007f175c80f534 in abort () at /usr/lib/libc.so.6
    #3  0x00007f175cf05ee4 in qt_assert(char const*, char const*, int) () at /usr/lib/libQt5Core.so.5
    #4  0x000055deb2e67e1c in mixxx::(anonymous namespace)::handleMessage(QtMsgType, QMessageLogContext const&, QString const&) (type=<optimized out>, context=<optimized out>, input=<optimized out>) at src/util/logging.cpp:355
    #5  0x00007f175cf47128 in  () at /usr/lib/libQt5Core.so.5
    #6  0x00007f175cf3fd8a in  () at /usr/lib/libQt5Core.so.5
    #7  0x00007f175cf06526 in QMessageLogger::critical(char const*, ...) const () at /usr/lib/libQt5Core.so.5
    #8  0x000055deb2e5c720 in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x55deb39bd0db "isValid()", file=file@entry=0x55deb39bbf30 "src/track/bpm.h", line=line@entry=53, function=function@entry=0x55deb39bbf08 "double mixxx::Bpm::value() const") at gsrc/util/assert.h:9
    #9  0x000055deb2ee7e7e in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x55deb39bbf08 "double mixxx::Bpm::value() const", line=53, file=0x55deb39bbf30 "src/track/bpm.h", assertion=0x55deb39bd0db "isValid()") at gsrc/util/assert.h:18
    #10 mixxx::Bpm::value() const (this=<synthetic pointer>) at src/track/bpm.h:53
    #11 mixxx::operator*(mixxx::Bpm, double) (multiple=1, bpm=...) at src/track/bpm.h:160
    #12 SyncControl::setLocalBpm(mixxx::Bpm) (this=<optimized out>, localBpm=...) at src/engine/sync/synccontrol.cpp:567
    #13 0x000055deb34c7ba3 in EngineBuffer::postProcess(int) (this=0x55deb56eb060, iBufferSize=2048) at src/engine/enginebuffer.cpp:1318
    #14 0x000055deb3139023 in EngineMaster::processChannels(int) (this=0x55deb5449440, iBufferSize=<optimized out>) at src/engine/enginemaster.cpp:383
    #15 0x000055deb31394f7 in EngineMaster::process(int) (this=0x55deb5449440, iBufferSize=iBufferSize@entry=2048) at src/engine/enginemaster.cpp:410
    #16 0x000055deb2f91d0b in SoundManager::onDeviceOutputCallback(long) (this=<optimized out>, iFramesPerBuffer=iFramesPerBuffer@entry=1024) at src/soundio/soundmanager.cpp:596
    #17 0x000055deb32dd794 in SoundDevicePortAudio::callbackProcessClkRef(long, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (this=0x55deb553e6b0, framesPerBuffer=1024, out=<optimized out>, in=<optimized out>, timeInfo=<optimized out>, statusFlags=<optimized out>) at src/soundio/sounddeviceportaudio.cpp:965

This happens because `newLocalBpm` is invalid when `localBpm` is
invalid. Trying to do sync decks while no tempo information is available
does not make sense, so we only synchronize decks if the local BPM is
available.
Be-ing pushed a commit that referenced this pull request Jun 22, 2023
@m0dB
Merge pull request #2 from daschuer/vumeter_qglwidget_2
0175001 
Segfault Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @Be-ing